Skip to content

Search feature enhancements#1841

Merged
nsarrazin merged 6 commits into
huggingface:mainfrom
vijay2904:enhancement/search-feature-tasks
Jun 2, 2025
Merged

Search feature enhancements#1841
nsarrazin merged 6 commits into
huggingface:mainfrom
vijay2904:enhancement/search-feature-tasks

Conversation

@vijay2904

Copy link
Copy Markdown
Contributor

Features enhanced / added:

  1. Modified query logic to return all the matching snippets (not just the first N) using infinite scroll, in sets of 5.
  2. Added a short description to show the matching content with search keyword highlighted in bold.
  3. Added padding to the search icon in the nav menu.
  4. Added ctrl/cmd k to the end of the placeholder for users to know.

@vijay2904 vijay2904 mentioned this pull request May 30, 2025
2 tasks

@nsarrazin nsarrazin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I modified a few things so we find the matched stem more reliably but it works well! Appreciate it. Will deploy 🚀

@nsarrazin
nsarrazin merged commit 21dd968 into huggingface:main Jun 2, 2025
@vijay2904

Copy link
Copy Markdown
Contributor Author

Thanks for accepting my changes. MongDB is not my strong forte >_<.

I was able to learn from your modifications. Thank you so much.

If you think my contribution is worth it, please assign the issue to me before closing.

  • By the way, I would like to write an article on my blog about this contribution with your permission.

maksym-work pushed a commit to siilats/chat-ui that referenced this pull request Jul 2, 2025
* Added infinite scrolling to search feature.

* Added code to highlight the search keyword in search description

* feat: improve description layout

* feat: improve search context finding

* fix: remove all debug bits

---------

Co-authored-by: Nathan Sarrazin <sarrazin.nathan@gmail.com>
Matsenas pushed a commit to Matsenas/chat-ui that referenced this pull request Jul 4, 2025
* Added infinite scrolling to search feature.

* Added code to highlight the search keyword in search description

* feat: improve description layout

* feat: improve search context finding

* fix: remove all debug bits

---------

Co-authored-by: Nathan Sarrazin <sarrazin.nathan@gmail.com>
Matsenas pushed a commit to Matsenas/chat-ui that referenced this pull request Jul 4, 2025
* Added infinite scrolling to search feature.

* Added code to highlight the search keyword in search description

* feat: improve description layout

* feat: improve search context finding

* fix: remove all debug bits

---------

Co-authored-by: Nathan Sarrazin <sarrazin.nathan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants