Add customizable CTA label to feature announcements#2400
Merged
Conversation
Swap the home-screen feature announcement toast from "Introducing Artifacts" to a Gemma-4-31B / Cerebras inference message with a call-to-action linking to the model page. Adds an optional `cta` field to feature announcements so the toast link label can be customized (defaults to "Learn more"), used here to render "Go to the model". Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PHfp4To6qTDrjFF5Dace1d
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9c2c537ece
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Light + dark render of the Gemma-4-31B / Cerebras announcement toast, referenced from the PR description. Lives under .github/media so it is outside the app bundle; safe to drop before merge. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PHfp4To6qTDrjFF5Dace1d
The toast rendered announcement.link directly as the anchor href, so an app-relative link like /models/... resolved without APP_BASE (e.g. /chat) in prod, sending the CTA to the wrong origin. Prepend `base` from $app/paths for internal links, matching how the rest of the app builds model links; external URLs are left untouched. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PHfp4To6qTDrjFF5Dace1d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for customizable call-to-action (CTA) labels in feature announcements, allowing announcements to override the default "Learn more" text with custom labels like "Go to the model".
Preview
The home-screen announcement toast (light + dark):
Changes
cta?: stringfield toFeatureAnnouncementinterfacegetActiveAnnouncement()to extract and trim thectafield from announcement JSON, treating blank/whitespace-only values as undefinedFeatureAnnouncementToast.svelteto display custom CTA label when provided, falling back to "Learn more" default.envand example configurations to document the newctafieldImplementation Details
The CTA label processing uses the existing
asTrimmedString()utility to handle whitespace normalization, ensuring consistent behavior with other announcement fields. Blank strings are converted toundefinedto maintain a clean data model.https://claude.ai/code/session_01PHfp4To6qTDrjFF5Dace1d