-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat: sync models from router (+10 added, 6 reasoning-capable, 6 artifacts, -0 removed) #2403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+20
−0
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two overrides mark Ornith as
supportsReasoning, which in this app specifically means the model accepts a low/medium/highreasoning_effortknob (src/lib/server/models.ts), so the chat UI exposes the Effort selector and forwards the selected value. Ornith's HF/DeepInfra docs describe it as always emitting a<think>/reasoning_contenttrace via a parser, not as supporting configurable effort levels; when users choose Low/Medium/High, HuggingChat will send an unsupportedreasoning_effortparam for these models. Drop the flag or add provider-specific handling before enabling it; the same issue is present inchart/env/dev.yaml.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed — dropped
supportsReasoningfrom both Ornith entries inprod.yamlanddev.yaml(commit 35866d0), keepingsupportsArtifacts.Verified against the HF model card: Ornith always opens with a
<think>/reasoning_contenttrace via a parser but documents noreasoning_effort/ configurable effort levels, so it doesn't match this app'ssupportsReasoningsemantics (accepts a low/medium/highreasoning_effortknob). One small correction to the impact: DeepInfra's reasoning docs sayreasoning_efforton a model that doesn't support it "has no effect" (silently ignored, not an error), so the practical bug was an inert Effort selector rather than a broken request — but removing the flag is still the right call.For reference, the other new reasoning flags were re-checked and do document
reasoning_effort: Step-3.7-Flash (StepFun docs), MiMo-V2.5-Pro (AI/ML API docs), and Kimi-K2-Thinking (effort levels), so those stay.Generated by Claude Code