CI: fix a few issues and revert debug flag#51
Merged
Conversation
…atch The debug cap (TASK_DEBUG_MAX_TASKS=3) was added alongside the runner crash self-reporting (#50) to keep manual triage retriggers a short crash-repro cycle. Now that the runner-startup crash is diagnosed and self-reporting is in place, remove the temporary cap so serge executes every /tasks request in a burst again. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
`trim()` is not a valid GitHub Actions expression function (the only string helpers are contains/startsWith/endsWith/format/join). Using it in the job `if:` made the workflow fail to compile — a startup failure with zero jobs run (e.g. run 28783571654). startsWith(comment.body, '@askserge ') already enforces "@askserge as the first word" since it matches from the literal start of the body, so dropping trim() keeps the #45 intent; we only lose tolerance for leading whitespace before the mention, which is an acceptable edge case. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
tarekziade
changed the title
Add an `actionlint` job to tests.yml that the test/helm jobs depend on,
so workflow files are statically checked on every PR. actionlint
validates ${{ }} expressions (including that called functions exist),
which catches errors like the invalid trim() that broke ai-review.yml —
those otherwise surface only as a startup failure with zero jobs run.
Also fix the same invalid trim() in the docs/github-action.md workflow
example so users don't copy a workflow that fails to compile.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
tarekziade
changed the title
tarekziade
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three related changes.
1. Drop the
TASK_DEBUG_MAX_TASKSdebug capRemoves the temporary
TASK_DEBUG_MAX_TASKS: "3"cap (and comment) fromdeploy/helm/env/prod.yaml. Added alongside runner crash self-reporting (#50) to keep manual triage retriggers short — its comment said "Remove once the runner-startup crash is diagnosed." Now the nightly triage runs the full batch again instead of only the first 3. The mechanism inreviewbot/webapp.pystays (unset = no cap) as a debug knob.2. Fix
ai-review.ymlstartup failuretrim()is not a valid GitHub Actions expression function, so its use in the jobif:(added in #45) made the workflow fail to compile — a startup failure with zero jobs run, e.g. run 28783571654. Dropped it;startsWith(comment.body, '@askserge ')already enforces "@askserge as the first word", so #45's intent is preserved (only leading-whitespace tolerance is lost). Same fix applied to the workflow example indocs/github-action.md.3. Lint workflows in CI so this can't recur
Adds an
actionlintjob totests.ymlthat thetestandhelmjobs depend on (runs first, gates the rest). actionlint statically validates${{ }}expressions — including that called functions exist — so an invalid function liketrim()fails the PR check with a clear message instead of silently producing a zero-job startup failure. Pinned to actionlint v1.7.11.🤖 Generated with Claude Code