Refactor Dockerfile-cuda-all into compute-cap stages#843
Draft
alvarobartt wants to merge 5 commits intomainfrom
Draft
Refactor Dockerfile-cuda-all into compute-cap stages#843alvarobartt wants to merge 5 commits intomainfrom
Dockerfile-cuda-all into compute-cap stages#843alvarobartt wants to merge 5 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR refactors the
Dockerfile-cuda-allimage to build one router binary per supported compute capability in a dedicated build stage, instead of building all variants from a shared mutable CUDA toolchain state.Whilst moving from
dynamic-linkingtostatic-linking+nvprunefixes the startup delay of ~3 minutes when running the...-cuda-1.9container, it also implies that the image is larger given that it needs to prune and statically link CUDA to every binary.Fixes #837
Before submitting
instasnapshots?Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR.