fix: allow num_labels property to return None when id2label is unset#47069
Open
SebTardif wants to merge 2 commits into
Open
fix: allow num_labels property to return None when id2label is unset#47069SebTardif wants to merge 2 commits into
SebTardif wants to merge 2 commits into
Conversation
The property was annotated as returning int but returned None when id2label is missing, which contradicts the type and can break type checkers and careful callers. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
Contributor
CI recapDashboard: View test results in Grafana |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PretrainedConfig.num_labelswas annotated as-> intbut returnedNonewhenid2labelis not set.Change
Use
int | Noneand document the optional return value.Testing
Type annotation aligns with runtime behavior; no logic change.