Skip to content

Avoid extra reconstruction request that returns 416 #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
assafvayner wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Avoid extra reconstruction request that returns 416 #778

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
13ef815
Avoid extra reconstruction request that returns 416
assafvayner Apr 4, 2026
3491fa4
lock
assafvayner Apr 4, 2026
9ff4ed6
rm no op
assafvayner Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions wasm/hf_xet_thin_wasm/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions xet_data/src/file_reconstruction/reconstruction_terms/manager.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,6 +283,14 @@ impl ReconstructionTermManager {
let file_hash = self.file_hash;

let jh = tokio::task::spawn(async move {
// Check if a previously completed block has already discovered the file end,
// making this request unnecessary. This avoids sending a request that would
// return a 416 Range Not Satisfiable.
if prefetch_block_range.start >= known_final_byte_position.load(Ordering::Relaxed) {
known_final_byte_position.fetch_min(prefetch_block_range.start, Ordering::Relaxed);
Copy link
Copy Markdown
Collaborator

@hoytak hoytak Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this line is a no-op -- this only triggers if prefetch_block_range.start is already >= known_final_byte_position, which means known_final_byte_position is already at the min of the two.

return Ok(None);
}

let result = retrieve_file_term_block(client, file_hash, prefetch_block_range).await;

// See if we're done with the file.
Expand Down
Loading