Merged
Conversation
seanses
reviewed
Apr 9, 2026
xet_client/src/common/http_client.rs
Outdated
| @@ -311,7 +311,7 @@ impl AuthMiddleware { | |||
| ClientError::AuthError(err) | |||
| }) | |||
| .inspect(|_token| { | |||
Collaborator
There was a problem hiding this comment.
If we are not inspecting the _token maybe delete this for good
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6193c26. Configure here.
Co-authored-by: Assaf Vayner <assafvayner@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Very chatty log for when there is a valid token, but says token refresh occurred which may not actually be true.
downleveled and corrected this log and added an actual info on token refresh success (error gets logged by the caller)
Note
Low Risk
Low risk: only adjusts logging around CAS auth token refresh without changing token refresh logic or request behavior.
Overview
Removes the unconditional "token refresh successful" info log from
AuthMiddleware::get_tokenso normal requests that reuse a still-valid token no longer claim a refresh happened.Adds an
info!log inTokenProvider::get_valid_tokenthat emits only after a successful refresh (including the new expiry), while keeping failure logging in the middleware.Reviewed by Cursor Bugbot for commit 2a9215c. Bugbot is set up for automated code reviews on this repo. Configure here.