fix(release): wire .ico for Windows MSI + drop Intel macOS runner#4
Merged
Conversation
Two issues from the last release attempt: 1. Windows MSI bundler failed with "Couldn't find a .ico icon" because bundle.icon in tauri.conf.json only listed icon.png. Add the full per-platform icon list (32×32 / 128×128 / 128@2x for Linux, .icns for macOS, .ico for Windows) so each bundler picks the format it needs. 2. The macos-13 runner pool is heavily backlogged (Intel jobs stall for 10+ min in "Waiting for a runner"), and Intel Macs are a vanishing share of users in 2026. Cut the matrix to Apple Silicon + Windows so releases finish in ~10 min. Co-Authored-By: Claude Opus 4 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two issues blocked the last release attempt — fixing both so the next
v*tag can finish cleanly.1. Windows MSI:
Couldn't find a .ico icontauri.conf.jsononly listedicons/icon.pnginbundle.icon, but the MSI bundler scans that array for a.icofile and bails out when it doesn't find one. Expand the array to cover every platform's expected format:Each bundler picks what it needs (Linux → PNGs, macOS →
.icns, Windows →.ico).2. Drop the Intel macOS runner
The
macos-13runner pool is heavily backlogged — jobs stall in "Waiting for a runner to pick up this job…" for 10+ minutes. Intel Macs are a vanishing share of users in 2026 (Apple completed the ARM transition in late 2020). Cut the matrix to Apple Silicon + Windows so releases finish in ~10 min instead of stalling on Intel.(This was originally on the now-deleted
feat/auto-updatebranch but didn't carry through tochore/embed-updater-pubkeywhen the new branch was cherry-picked. Re-applying here.)Test plan
v0.1.0tag.msiwithout the "Couldn't find a .ico icon" errorlatest.jsonshows up in the Release artifacts (sign secrets already set in PR chore(updater): embed signing public key #3)