Conversation
Puma 7.2.0 -> 8.0.2, selenium-webdriver 4.41.0 -> 4.46.0. `parallel` reaches the lockfile only through rubocop and takes no part in running the specs. The suite was flaky before the bumps — delete_user_spec failed in 42% of master's runs — so the rest of this is the baseline they need. * Puma 8 binds to :: rather than 0.0.0.0 once a non-loopback IPv6 interface is up, which would leave the address it listens on depending on the host it boots at. Pin it, as config/unicorn.rb does. Puma is a development and test dependency; production runs on unicorn. * The Capybara server ran on Threads '0:1' with queue_requests off, which is puma#876: the pool trims its last thread while the server waits for one, and with no reactor to hold the request it waits for a worker nothing will spawn. Run it 1:1, as production does. * delete_user_spec: signin does not wait for the login to complete, and the spec visited /users straight after, cancelling the in-flight POST. Add the barrier the other feature specs have. * expect_widget_presence: all() ignores :wait unless a count expectation is given, so it returned an empty list before the widget had rendered. Use have_css. * Drop Capybara.automatic_reload = false. It disables the re-lookup of stale nodes and is behind the "stale element reference" and "Node with given id does not belong to the document" errors. * translation_spec: the widget picks its translations by the locale the page handed it when it mounted, so a locale set mid-example never reached it. Render the page again on the spot. * The progress formatter prints one dot per example on a single unterminated line, and CI renders logs line by line, so a run only appeared once it ended. One line per example instead. * Provision yarn with corepack, which takes the version from packageManager.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stabilize the feature suite before bumping major gem versions, so that the effect of the bump can be measured against a green baseline.