Make the keymap selectors more specific.#12
Open
wxs wants to merge 1 commit intohydra-synth:masterfrom
Open
Conversation
Shift-enter conflicts with Hydrogen, a very popular Atom package. By making most of the keymaps specific to when Hydra is enabled, they play nicely together.
|
This is great -- solved my problem (and I don't see a downside to it!) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, not sure what your feeling about PRs is. This change made the Atom package more useful for me, hopefully the same goes for some other users. Let me know if this is helpful or whether you'd rather I approach it another way.
Shift-enter conflicts with Hydrogen, a very popular Atom package. By making most of the keymaps (except for the toggle keymap) specific to when Hydra is enabled, they play nicely together.