Skip to content

fix: audit fixes for 1.1.11 #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PRavaga wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: audit fixes for 1.1.11 #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/app/components/AliasManagePage/hook/useAlias.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ export const useAlias = ({
}
}

console.log(mode, data);
//
} catch (e) {
console.log(e);
setTransactionSuccess(false);
Expand All @@ -145,7 +145,7 @@ export const useAlias = ({
if (mode === 'edit') return null;
if (aliasInput.isEmpty) return 'This field is required';
if (aliasInput.minLengthError) return 'Alias must be minimum 6 symbols';
if (isAliasRegistred) return 'Alias name already exits';
if (isAliasRegistred) return 'Alias name already exists';
return null;
}, [aliasInput, isAliasRegistred, mode]);

Expand Down
2 changes: 1 addition & 1 deletion src/app/components/AliasTransfer/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ const AliasTransfer = () => {
/>

<p className={styles.main__transactionInfo_text}>
{transactionSuccess ? `Alias transfered!` : 'Transaction failed!'}
{transactionSuccess ? `Alias transferred!` : 'Transaction failed!'}
</p>

{!transactionSuccess && (
Expand Down
1 change: 0 additions & 1 deletion src/app/components/Wallet/Wallet.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import React, { Dispatch, SetStateAction, useContext, useRef, useState } from 'react';
import Decimal from 'decimal.js';
import { styleText } from 'util';
import copyIcon from '../../assets/svg/copy.svg';
import dotsIcon from '../../assets/svg/dots.svg';
import sendIcon from '../../assets/svg/send.svg';
Expand Down
14 changes: 9 additions & 5 deletions src/background/background.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,9 +318,13 @@ async function processRequest(request: RequestType, sender: Sender, sendResponse
};
updateUserData({
apiCredentials,
}).then(() => {
sendResponse({ success: true });
});
})
.then(() => {
sendResponse({ success: true });
})
.catch(() => {
sendResponse({ error: 'Failed to save credentials' });
});
break;

case 'PING_WALLET':
Expand Down Expand Up @@ -574,7 +578,7 @@ async function processRequest(request: RequestType, sender: Sender, sendResponse
createAlias({
address: String(request.address),
alias: String(request.alias),
comment: request.comment,
comment: request.comment ? String(request.comment) : undefined,
})
.then((res) => sendResponse(res))
.catch(() => sendResponse({ error: 'Internal error' }));
Expand All @@ -585,7 +589,7 @@ async function processRequest(request: RequestType, sender: Sender, sendResponse
updateAlias({
address: String(request.address),
alias: String(request.alias),
comment: request.comment,
comment: request.comment ? String(request.comment) : undefined,
})
.then((res) => sendResponse(res))
.catch(() => sendResponse({ error: 'Internal error' }));
Expand Down