[codex] resolve query tables by SQL name - #119
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates Collectivus query SQL so table names are resolved from the parsed Squirreling AST instead of being limited to a prebuilt fixed table map. SQL can now inject only the referenced built-in or collected tables, including original quoted collection names such as
"random-log".It also makes
--daterepeatable for multi-day partition unions and teachesctvs query schema <table>to resolve schemas for both built-in tables andctvs collecttables.Impact
proxy_messages.proxy_messages,logs, andgascity_messages.collectivus-queryskill guidance throughctvs skills install.Validation
npm test -- test/cli/query.test.js test/cli/collect.test.js test/cli/collect.glob.test.js test/skills/install.test.js test/skills/install_bundle.test.jsnpm run typechecknpm run lint(passes with existing warnings)node bin/cli.js skills install --client all --forceproxy_messagesqueries and multi-tableUNION ALLqueries over built-insrandom_logplus quoted"other-log"