Defer parquet scan column planning - #173
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parquetScanis a lazy API, but it previously built column read plans eagerly for every candidate row group.This refactors planning into two stages:
parquetPlanGroupsselects candidate row groups and row ranges.parquetPlanGroupbuilds column chunk and byte-range plans for one group.parquetPlancomposes both stages, preserving existingparquetReadbehavior.parquetScannow performs only group planning during initialization and creates a one-column plan whenreadColumnis called.This avoids inspecting and planning unused columns while keeping row-group pruning, page ranges, offset indexes, and scan caching behavior unchanged.
Performance
Local benchmark using a 170 MB Parquet file with 129 row groups:
Scan initialization is approximately 3.3× faster. Full-column read performance is effectively unchanged within benchmark noise.
The existing full-file
parquetReadObjectsbenchmark improved from a median of 1,111 ms to 1,025 ms, though it does not exercise theparquetScanpath directly.