Conversation
Signed-off-by: munapower <mmunaro@hotmail.com>
Signed-off-by: munapower <mmunaro@hotmail.com>
Signed-off-by: munapower <mmunaro@hotmail.com>
…loyment descriptor specific for Mac M1 Signed-off-by: munapower <mmunaro@hotmail.com>
Signed-off-by: munapower <mmunaro@hotmail.com>
Signed-off-by: munapower <mmunaro@hotmail.com>
Signed-off-by: munapower <mmunaro@hotmail.com>
…e containers Signed-off-by: munapower <mmunaro@hotmail.com>
Signed-off-by: munapower <mmunaro@hotmail.com>
mbrandenburger
left a comment
mbrandenburger
left a comment
There was a problem hiding this comment.
Thank you @munapower for creating this PR! I think this PR goes into the right direction and even brings some color into our terminals :)
Once, the example is running again - please remove the commented out lines which are not needed anymore.
| FABRIC_BIN_DIR="${FABRIC_BIN_DIR:-${FABRIC_PATH}/build/bin}" | ||
| FABRIC_BIN_DIR="${FPC_PATH}/fabric/_internal/bin" |
There was a problem hiding this comment.
should it be better FABRIC_BIN_DIR="${FABRIC_BIN_DIR:-${FPC_PATH}/fabric/_internal/bin}"
| C_RESET='\033[0m' | ||
| C_RED='\033[0;31m' | ||
| C_GREEN='\033[0;32m' | ||
| C_BLUE='\033[0;34m' | ||
| C_YELLOW='\033[1;33m' | ||
| # successln echos in green color | ||
| function successln() { | ||
| println "${C_GREEN}${1}${C_RESET}" | ||
| } |
There was a problem hiding this comment.
I like a bit of color :)
There was a problem hiding this comment.
we are just using green in this script?
| rm -rf ${cryptoConfigDir} | ||
| rm -rf ${channelArtifactsDir} | ||
| rm -rf ${packageDir} | ||
| rm -rf $cryptoConfigDir | ||
| rm -rf $channelArtifactsDir | ||
| rm -rf $packageDir |
There was a problem hiding this comment.
I guess we are not really have a strong consistent use of variable with an without {}. However, if we would like to remove them here, shouldn't we do it in the entire script? WDYT?
| minikube image load fpc/ercc:latest | ||
| minikube image load fpc/fpccc:latest | ||
| minikube image load fpc/fpcclient:latest |
There was a problem hiding this comment.
Do we need to update our minicube version as well in order to use image load instead of cache add?
2 participants
What this PR does / why we need it:
fixes k8s sample
Which issue(s) this PR fixes:
Fixes #926
Special notes for your reviewer:
Does this PR introduce a user-facing changes and/or breaks backward compatability?:
yes, changes to readme