fix: improve ServiceAccount reconciliation with smart patching - #288
Merged
Merged
Conversation
Enhance the ServiceAccount upsert logic to avoid unnecessary updates by: - Only patching when labels or controller references have changed - Using merge patches instead of full updates to preserve other fields - Adding helper functions for label comparison and merging - Implementing proper owner reference validation This reduces API server load and prevents conflicts with other controllers that may modify ServiceAccount resources. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
dmolik
reviewed
Sep 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #287
Enhance the ServiceAccount upsert logic to avoid unnecessary updates by:
This reduces API server load and prevents conflicts with other controllers that may modify ServiceAccount resources.