feat: Update default make setup-consultation mode#132
Open
tnetennba3 wants to merge 2 commits intomainfrom
Open
feat: Update default make setup-consultation mode#132tnetennba3 wants to merge 2 commits intomainfrom
make setup-consultation mode#132tnetennba3 wants to merge 2 commits intomainfrom
Conversation
tnetennba3
force-pushed
the
feat/update-setup-consultation-default-mode
branch
from
ec19f06 to
25f666f
Compare
So that we avoid setting up a consutlation using previous data as I just did.
tnetennba3
force-pushed
the
feat/update-setup-consultation-default-mode
branch
from
25f666f to
ec46c76
Compare
Collaborator
|
LGTM - but I don't think i've got permission to give a review |
If we don't do this, the files that are unchanged across runs (e.g., questions that were included in a previous run) will remain. This can cause issues if we specifically don't want to include these files in the latest consultation upload.
jjuritzno10
approved these changes
Apr 24, 2026
Collaborator
jjuritzno10
left a comment
jjuritzno10
left a comment
There was a problem hiding this comment.
Very nice - very minor and up to you, but consider making "until" and enum.
| question_understanding_path: Path, | ||
| output_dir: Path, | ||
| validate_only: bool = False, | ||
| until: str = "upload", |
Collaborator
There was a problem hiding this comment.
I like how this now moves in phases "until" a condition is reached. Consider making "until" and Enum?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So that we avoid setting up a consutlation using previous data as I just did.