Skip to content

feat: Introduce use_httponly_jwt_cookie method #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AbhijithKonnayil wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: Introduce use_httponly_jwt_cookie method #723

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions dj_rest_auth/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,10 @@ def login(self):
if api_settings.SESSION_LOGIN:
self.process_login()

def get_response(self):
def use_httponly_jwt_cookie(self, request):
return api_settings.JWT_AUTH_HTTPONLY

def get_response(self, request):
serializer_class = self.get_response_serializer()

if api_settings.USE_JWT:
Expand All @@ -84,7 +87,7 @@ def get_response(self):
access_token_expiration = (timezone.now() + jwt_settings.ACCESS_TOKEN_LIFETIME)
refresh_token_expiration = (timezone.now() + jwt_settings.REFRESH_TOKEN_LIFETIME)
return_expiration_times = api_settings.JWT_AUTH_RETURN_EXPIRATION
auth_httponly = api_settings.JWT_AUTH_HTTPONLY
auth_httponly = self.use_httponly_jwt_cookie(request)

data = {
'user': self.user,
Expand Down Expand Up @@ -125,7 +128,7 @@ def post(self, request, *args, **kwargs):
self.serializer.is_valid(raise_exception=True)

self.login()
return self.get_response()
return self.get_response(request)


class LogoutView(APIView):
Expand Down