Refactor: Use static version parsing in setup.py#737
Open
RinZ27 wants to merge 2 commits into
Open
Conversation
Owner
|
This changes many things which are outside the scope of the intent defined in the PR title/summary. |
Author
|
@iMerica My apologies for the noise in the initial commit. I've just reverted the unrelated changes to setup.py (dependency versions, classifiers, etc.) and kept only the static version parsing via regex as originally intended. Also verified that the install_requires and other metadata now match the master branch exactly. Thanks for catching that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parsing the version string using
exec()during package setup introduces unnecessary runtime dependencies and potential side effects. While functional, a more resilient and idiomatic approach involves static extraction of the version attribute fromdj_rest_auth/__version__.pywithout code execution.Implementing a regex-based search for the
__version__variable ensures the setup process remains focused and secure across different environments. This refactoring aligns with modern Python packaging standards and eliminates the risk associated with dynamic evaluation of external files during installation.