fix(ci): remove openssl-sys dependency via git2 default-features#209
Merged
Conversation
PR#204 switched reqwest/tokio-tungstenite to rustls but git2 still pulled in openssl-sys through its default "https" and "ssh" features. Since the project only uses git2 for local repository operations (init, commit, status, reset, checkout, branches), these network features are unnecessary. Disable git2 default features to completely eliminate openssl-sys, libssh2-sys, and openssl-probe from the dependency tree, fixing the cross-compilation failure on x86_64-apple-darwin CI target.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git2default features (https,ssh) to completely eliminateopenssl-sysfrom the dependency treereqwest/tokio-tungstenite, butgit2still pulledopenssl-sysvialibgit2-sys→libssh2-sysgit2for local operations (init, commit, status, reset, checkout, branches) — no network features neededRoot Cause
The
x86_64-apple-darwincross-compilation failure at run #25598413909 was caused byopenssl-sysstill being in the dependency tree throughgit2's default features.Changes
Cargo.toml:git2 = "0.20"→git2 = { version = "0.20", default-features = false }Cargo.lock: removesopenssl-sys,libssh2-sys,openssl-probe 0.1.6Test plan
cargo tree -i openssl-sysconfirms package no longer exists in treecargo check -p aionui-apppassescargo check -p aionui-filepasses