refactor(app): introduce commands/ module with layered bootstrap for subcommands#283
Merged
Conversation
Extract three helpers so async_main reads as a thin dispatcher: - resolve_work_dir: --work-dir > AIONUI_WORK_DIR env > --data-dir - materialize_builtin_skills: builtin-skills corpus + stale dir cleanup - run_server: full HTTP server startup/shutdown loop async_main now matches on the parsed subcommand and delegates. No behavioral change.
…otstrap - Relocate bridge, team_guide, team_stdio into src/commands/ directory - Extract init_environment (logging + config) and init_data_layer (materialize + db) as reusable bootstrap layers - Isolate HTTP server logic into commands/server.rs - Remove pub mod exports from lib.rs (these are binary-private modules) - Refactor idle_scanner to accept configurable scan interval and use seconds-based timeout
`default_idle_timeout_is_5_minutes` and `scan_interval_is_60_seconds` just asserted that two constants equal their literal definitions, so they had no value beyond restating the source. The 5-minute test was also already broken (asserted 300_000 against `DEFAULT_IDLE_TIMEOUT_SECS`).
This was referenced May 16, 2026
piorpua
pushed a commit
that referenced
this pull request
May 16, 2026
🤖 I have created a release *beep* *boop* --- ## [0.1.4](v0.1.3...v0.1.4) (2026-05-16) ### Features * **ai-agent:** log every CLI detection + add doctor subcommand ([#285](#285)) ([5ef6d0a](5ef6d0a)) * **runtime:** full shell-style command in spawn logs ([#278](#278)) ([dd51616](dd51616)) ### Bug Fixes * **ai-agent:** negotiate OpenClaw protocol v3..v4 ([#288](#288)) ([dfeece0](dfeece0)) * **team:** model routing + schema unification + lazy warm mode persistence ([#286](#286)) ([199a392](199a392)) ### Performance Improvements * **team:** lazy warm — only start agent processes on first message ([#282](#282)) ([6281f31](6281f31)) ### Code Refactoring * **app:** extract CLI definitions to cli.rs ([#280](#280)) ([5685d52](5685d52)) * **app:** introduce commands/ module with layered bootstrap for subcommands ([#283](#283)) ([1216597](1216597)) * **app:** replace argv sniffing with clap Subcommand for mcp-* helpers ([#277](#277)) ([c3d137c](c3d137c)) * **app:** split monolithic lib.rs/main.rs into per-module files ([#284](#284)) ([f3462cb](f3462cb)) * rename binary from aionui-backend to aioncli ([#289](#289)) ([30eeca3](30eeca3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cli.rs, subcommand implementations tosrc/commands/directoryinit_environment→init_data_layer→AppServices) so future subcommands can compose only the initialization they needbridge,team_guide,team_stdiofrom lib.rs public modules to binary-privatecommands/moduleidle_scannerto accept configurable scan interval and use seconds-based timeoutMotivation
Preparing for upcoming CLI subcommands (e.g.
agent add) that need database access but not the full HTTP server stack. The layered bootstrap pattern allows each subcommand to opt into only the initialization layers it requires.Structure