Skip to content

fix(agent): guard internal Aion CLI command overrides#538

Merged
kaizhou-lab merged 3 commits into
mainfrom
fix/internal-aion-cli-override-guard
Jun 29, 2026
Merged

fix(agent): guard internal Aion CLI command overrides#538
kaizhou-lab merged 3 commits into
mainfrom
fix/internal-aion-cli-override-guard

Conversation

@kaizhou-lab

Copy link
Copy Markdown
Contributor

Summary

  • reject command overrides for the internal Aion CLI agent
  • ignore and mask legacy Aion CLI command overrides at registry/read time
  • add migration 016 to clear polluted internal Aion CLI override data

Tests

  • CARGO_TARGET_DIR=/tmp/aioncore-codex-target cargo test -p aionui-ai-agent decode_row_ignores_internal_aion_cli_command_override
  • CARGO_TARGET_DIR=/tmp/aioncore-codex-target cargo test -p aionui-app --test agent_integration_e2e internal_aion_cli_rejects_command_override
  • CARGO_TARGET_DIR=/tmp/aioncore-codex-target cargo test -p aionui-db --test cron_assistant_first_migration migration_016_clears_internal_aion_cli_command_override_only
  • CARGO_TARGET_DIR=/tmp/aioncore-codex-target cargo fmt --all -- --check
  • CARGO_TARGET_DIR=/tmp/aioncore-codex-target cargo test -p aionui-ai-agent
  • CARGO_TARGET_DIR=/tmp/aioncore-codex-target cargo test -p aionui-db
  • CARGO_TARGET_DIR=/tmp/aioncore-codex-target cargo clippy -p aionui-ai-agent -p aionui-db -p aionui-app -- -D warnings
  • CARGO_TARGET_DIR=/tmp/aioncore-codex-target cargo test -p aionui-app --test agent_integration_e2e
  • CARGO_TARGET_DIR=/tmp/aioncore-codex-target just push -u origin fix/internal-aion-cli-override-guard

Investigation notes

Sentry #81 shows PUT /api/agents/632f31d2/overrides polluted the internal Aion CLI row with command_override values like a web URL and irm https://claude.ai/install.ps1 | iex. The backend must treat this internal commandless agent as non-overridable regardless of caller.

@kaizhou-lab kaizhou-lab merged commit f141233 into main Jun 29, 2026
6 checks passed
@kaizhou-lab kaizhou-lab deleted the fix/internal-aion-cli-override-guard branch June 29, 2026 12:51
piorpua pushed a commit that referenced this pull request Jun 29, 2026
🤖 I have created a release *beep* *boop*
---


##
[0.1.39](v0.1.38...v0.1.39)
(2026-06-29)


### Bug Fixes

* **agent:** adapt aionrs compat API
([#528](#528))
([f4ad432](f4ad432))
* **agent:** guard internal Aion CLI command overrides
([#538](#538))
([f141233](f141233))
* **app:** reuse conversation service for channel messages
([#531](#531))
([dce8053](dce8053))
* **assistant:** preserve builtin override selections
([#535](#535))
([be4a81e](be4a81e))
* **file:** trust local workspace roots for fs routes
([#527](#527))
([8e6f32f](8e6f32f))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant