Skip to content

Add tests for string clip edge cases #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NailxSharipov merged 2 commits into from
Jan 27, 2026
Merged

Add tests for string clip edge cases #45

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81c03d3
add tests for string clip edge cases
mikhailofff Jan 27, 2026
73269da
refactor for correct variable name
mikhailofff Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
104 changes: 103 additions & 1 deletion iOverlay/src/string/clip.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,6 @@ impl IntClip for [IntPoint] {
}
}


#[cfg(test)]
mod tests {
use alloc::vec;
Expand Down Expand Up @@ -354,4 +353,107 @@ mod tests {
assert_eq!(result_0.len(), 3);
assert_eq!(result_1.len(), 2);
}

#[test]
fn test_tiny_shape() {
let path = vec![
IntPoint::new(-1, 0),
IntPoint::new(1, 0),
IntPoint::new(0, 1),
];

let result_0 = path.clip_line(
[IntPoint::new(0, -1), IntPoint::new(0, 2)],
FillRule::NonZero,
ClipRule { invert: false, boundary_included: false },
);

let result_1 = path.clip_line(
[IntPoint::new(0, -1), IntPoint::new(0, 2)],
FillRule::NonZero,
ClipRule { invert: true, boundary_included: false },
);

assert_eq!(result_0.len(), 1);
assert_eq!(result_1.len(), 2);
}

#[test]
fn test_shared_vertices_0() {
let path = vec![
IntPoint::new(-1, -1),
IntPoint::new(1, -1),
IntPoint::new(1, 1),
IntPoint::new(-1, 1),
];

let result_0 = path.clip_line(
[IntPoint::new(-1, -1), IntPoint::new(1, -1)],
FillRule::NonZero,
ClipRule { invert: false, boundary_included: false },
);

let result_1 = path.clip_line(
[IntPoint::new(-1, -1), IntPoint::new(1, -1)],
FillRule::NonZero,
ClipRule { invert: false, boundary_included: true },
);

assert_eq!(result_0.len(), 0);
assert_eq!(result_1.len(), 1);
}

#[test]
fn test_shared_vertices_1() {
let rect = vec![

@NailxSharipov NailxSharipov Jan 27, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to rename it to something neutral like path_0. It's not a rect right now

IntPoint::new(-2, -2),
IntPoint::new(2, -2),
IntPoint::new(3, 0),
IntPoint::new(-3, 0),
];

let path = vec![
IntPoint::new(-4, 1),
IntPoint::new(-2, -2),
IntPoint::new(2, -2),
IntPoint::new(4, 1),
];

let result_0 = rect.clip_path(&path, FillRule::NonZero,
ClipRule { invert: false, boundary_included: false },
);

let result_1 = rect.clip_path(&path, FillRule::NonZero,
ClipRule { invert: false, boundary_included: true },
);

assert_eq!(result_0.len(), 0);
assert_eq!(result_1.len(), 1);
}

#[test]
fn test_sliding_intersection() {
let path = vec![
IntPoint::new(0, 0),
IntPoint::new(2, 0),
IntPoint::new(2, 2),
IntPoint::new(1, 0),
IntPoint::new(0, 2),
];

let result_0 = path.clip_line(
[IntPoint::new(-3, 2), IntPoint::new(3, 2)],
FillRule::NonZero,
ClipRule { invert: false, boundary_included: false },
);

let result_1 = path.clip_line(
[IntPoint::new(-3, 2), IntPoint::new(3, 2)],
FillRule::NonZero,
ClipRule { invert: false, boundary_included: false },
);

assert_eq!(result_0.len(), 0);
assert_eq!(result_1.len(), 0);
}
}