Fix operator precedence in getContainerAsync token resolution#9069
Merged
Conversation
hl662
commented
Mar 9, 2026
hl662
force-pushed
the
hl662/fix-getContainerAsync-token-precedence
branch
from
9a68445 to
39b62e7
Compare
The `??` operator binds tighter than `?:`, causing the ternary to evaluate against the resolved `??` result rather than serving as the fallback. This silently replaced explicitly-provided access tokens with "". Fixes #9068 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
hl662
force-pushed
the
hl662/fix-getContainerAsync-token-precedence
branch
from
39b62e7 to
874e278
Compare
ben-polinsky
reviewed
Mar 9, 2026
Break up complex one-liner token resolution into early-return style per PR review feedback. Each condition now lives on its own line. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
johnnyd710
approved these changes
Mar 9, 2026
ben-polinsky
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
??operator binds tighter than?:, causing the ternary to evaluate against the resolved??result rather than serving as the fallback. This silently replaced explicitly-provided access tokens with "".Fixes #9068