Skip to content

Bugfix/default civilunits length koq #9071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
a-gagnon merged 2 commits into from
Mar 9, 2026
Merged

Bugfix/default civilunits length koq #9071

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6386952
Map CivilUnits.LENGTH to QuantityType.LengthEngineering by default.
a-gagnon Mar 9, 2026
4237981
Rush change file.
a-gagnon Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ...n/changes/@itwin/core-frontend/bugfix-default-civilunits-length-koq_2026-03-09-18-52.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@itwin/core-frontend",
"comment": "Fix default KOQ -> QuantityType map value for CivilUnits.LENGTH",
"type": "none"
}
],
"packageName": "@itwin/core-frontend"
}
18 changes: 9 additions & 9 deletions core/frontend/src/quantity-formatting/QuantityFormatter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,7 @@ export class QuantityTypeFormatsProvider implements FormatsProvider {
["DefaultToolsUnits.VOLUME", QuantityType.Volume],
["DefaultToolsUnits.LENGTH_COORDINATE", QuantityType.Coordinate],
["CivilUnits.STATION", QuantityType.Stationing],
["CivilUnits.LENGTH", QuantityType.LengthSurvey],
["CivilUnits.LENGTH", QuantityType.LengthEngineering],
["AecUnits.LENGTH", QuantityType.LengthEngineering]
]);

Expand Down Expand Up @@ -692,7 +692,7 @@ export class QuantityFormatter implements UnitsProvider {
try {
// force all cached data to be reinitialized
await IModelApp.quantityFormatter.onInitialized();
} catch(err) {
} catch (err) {
Logger.logWarning(`${FrontendLoggerCategory.Package}.quantityFormatter`, BentleyError.getErrorMessage(err), BentleyError.getErrorMetadata(err));
Logger.logWarning(`${FrontendLoggerCategory.Package}.quantityFormatter`, "An exception occurred initializing the iModelApp.quantityFormatter with the given UnitsProvider. Defaulting back to the internal units provider.");
// If there is a problem initializing with the given provider, default back to the internal provider
Expand Down Expand Up @@ -1128,13 +1128,13 @@ export class QuantityFormatter implements UnitsProvider {
return this._formatSpecsRegistry.get(name);
}

/**
* Populates the registry with a new FormatterSpec and ParserSpec entry for the given format name.
* @beta
* @param name The key used to identify the formatter and parser spec
* @param persistenceUnitName The name of the persistence unit
* @param formatProps If not supplied, tries to retrieve the [[FormatProps]] from [[IModelApp.formatsProvider]]
*/
/**
* Populates the registry with a new FormatterSpec and ParserSpec entry for the given format name.
* @beta
* @param name The key used to identify the formatter and parser spec
* @param persistenceUnitName The name of the persistence unit
* @param formatProps If not supplied, tries to retrieve the [[FormatProps]] from [[IModelApp.formatsProvider]]
*/
public async addFormattingSpecsToRegistry(name: string, persistenceUnitName: string, formatProps?: FormatProps): Promise<void> {
if (!formatProps) {
formatProps = await IModelApp.formatsProvider.getFormat(name);
Expand Down
Loading