-
Notifications
You must be signed in to change notification settings - Fork 242
Allow element to change its parent or model or both #9303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
khanaffan
wants to merge
9
commits into
master
Choose a base branch
from
affank/move-el
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+857
−3
Open
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
49033bc
Allow element to change its parent or model
khanaffan d5fbf5a
Added test to confirm if changeElementModel updates children
rschili c6e46d9
Enhance documentation and validation for element model changes
khanaffan 378be30
Merge branch 'master' into affank/move-el
khanaffan 5adf5bd
Invalidate source/target model cache in changeElementModel
khanaffan 03d6003
Merge remote-tracking branch 'origin/master' into affank/move-el
khanaffan c6959d6
Address review feedback on element move APIs
khanaffan 038046b
Clarify root-only element model moves
khanaffan 07d5522
Add coverage for element parent/model change edge cases
khanaffan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
common/changes/@itwin/core-backend/affank-move-el_2026-06-23-20-09.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "changes": [ | ||
| { | ||
| "comment": "Add EditTxn.changeElementParent and EditTxn.changeElementModel; add ElementError namespace.", | ||
| "type": "none", | ||
| "packageName": "@itwin/core-backend" | ||
| } | ||
| ], | ||
| "packageName": "@itwin/core-backend", | ||
| "email": "khanaffan@users.noreply.github.com" | ||
| } |
11 changes: 11 additions & 0 deletions
11
common/changes/@itwin/core-common/affank-move-el_2026-06-23-20-09.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "changes": [ | ||
| { | ||
| "comment": "Add EditTxn.changeElementParent and EditTxn.changeElementModel; add ElementError namespace.", | ||
| "type": "none", | ||
| "packageName": "@itwin/core-common" | ||
| } | ||
| ], | ||
| "packageName": "@itwin/core-common", | ||
| "email": "khanaffan@users.noreply.github.com" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.