fix in timezone: ensure UTC chain is not affected by host DST in startOf#3144
Open
EzequielArce wants to merge 1 commit into
Open
fix in timezone: ensure UTC chain is not affected by host DST in startOf#3144EzequielArce wants to merge 1 commit into
EzequielArce wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in the
timezoneplugin where calling.startOf('day')on a UTC instance returns an incorrect date if the host machine's local time is undergoing a Daylight Saving Time (DST) transition on that specific date.The Problem
In the original implementation,
proto.startOfhandles timezone shifting by formatting the date into a naive string (YYYY-MM-DD HH:mm:ss:SSS) and parsing it back using the default factoryd().When the target timezone is
UTCbut the host system (e.g.,America/Los_Angeles) experiences a DST transition (such as a 25-hour day), the core's default parsing falls back to the host's local clock constraints. This causes the underlying localDatemathematics to miscalculate the midnight boundary, leaking the host's DST anomaly into the final UTC object.Solution presented
When
this.$x.$timezoneis'UTC':I use
{ utc: true }in the configuration.Type of Change
Addresses #3123