fix(sql): preserve timezone-cast semantics for extraction ops#11984
Open
RedZapdos123 wants to merge 1 commit intoibis-project:mainfrom
Open
fix(sql): preserve timezone-cast semantics for extraction ops#11984RedZapdos123 wants to merge 1 commit intoibis-project:mainfrom
RedZapdos123 wants to merge 1 commit intoibis-project:mainfrom
Conversation
github-actions
bot
added
tests
Preserve timezone-aware timestamp cast behavior for extraction operations in Trino and DuckDB, including string/date casts to timezone-aware timestamps in DuckDB. Add targeted DuckDB regression coverage for timezone-cast hour/time extraction, timezone-aware epoch_seconds behavior, and Trino SQL generation using timezone functions. Fixes ibis-project#11965 Fixes ibis-project#11527 Fixes ibis-project#11211 Refs ibis-project#11879 Signed-off-by: Mridankan Mandal <iib2024017@iiita.ac.in>
RedZapdos123
force-pushed
the
fix-timezone-cast-regressions-11965
branch
from
79634d8 to
5f54bcb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the inconsistent timezone cast behavior across Trino and DuckDB for the issue patterns reported in the linked tickets. It updates Trino cast translation to use timezone functions for timezone aware extraction paths, and updates DuckDB timezone aware casts from string/date inputs so that epoch, and extraction operations use the correct instant semantics. It also adds targeted regression tests for timezone cast hour/time extraction, timezone aware epoch_seconds behavior, and Trino SQL timezone function generation.
Fixes #11965
Fixes #11527
Fixes #11211
Refs #11879