fix(bigquery): preserve parsed database in create_view return path#11988
Open
RedZapdos123 wants to merge 1 commit intoibis-project:mainfrom
Open
fix(bigquery): preserve parsed database in create_view return path#11988RedZapdos123 wants to merge 1 commit intoibis-project:mainfrom
RedZapdos123 wants to merge 1 commit intoibis-project:mainfrom
Conversation
Fixes ibis-project#11974 Signed-off-by: Mridankan Mandal <xerontitan90@gmail.com>
github-actions
bot
added
tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes BigQuery create_view with database values in project.dataset format as reported in #11974.
The issue is in the create_view return path: create_view parses the database into catalog/db for SQL generation, but then returns self.table(...) using the original database string. For inputs like my-project.my_dataset this reconstructs as my-project.my-project.my_dataset and then raises a ValueError.
This change keeps the parsed database tuple (catalog, db) when returning the created view expression.
It also adds a targeted unit regression test that exercises create_view with project.dataset input and asserts that the returned table lookup uses the parsed tuple.
Tested:
The screenshot of the tests for validation (run on WSL):
Fixes #11974