[patch] Fix orphaned app-install-iot-after-monitor task in pipeline#2200
Open
jvaneel-dwivedi wants to merge 5 commits intomasterfrom
Open
[patch] Fix orphaned app-install-iot-after-monitor task in pipeline#2200jvaneel-dwivedi wants to merge 5 commits intomasterfrom
jvaneel-dwivedi wants to merge 5 commits intomasterfrom
Conversation
Add app-install-iot-after-monitor as a dependency to both app-install-predict and post-install-verify to ensure: 1. Consistent 'Predict is installed after iot+monitor' logic regardless of installation order 2. Post-install verification waits for IoT completion even when Predict is skipped This addresses both scenarios: - When Predict runs: post-install-verify → app-install-predict → app-install-iot-after-monitor - When Predict is skipped: post-install-verify → app-install-iot-after-monitor (direct dependency)
…ncies Add approval-iot and approval-iot-after-monitor as dependencies to waitfor-predict task to ensure Predict FVT only starts after IoT installation is approved, since Predict depends on IoT completion.
- Fix waitfor-iot dependency: Change from approval-manage to approval-suite-verify * Restores correct dependency that existed before PR #2114 * Allows Manage and IoT to install in parallel after suite verification * Prevents unnecessary 8+ hour delays in pre-9.2 IoT FVT scenarios - Fix waitfor-predict dependency: Add IoT approval dependencies * Add approval-iot and approval-iot-after-monitor to runAfter * Prevents waitfor-predict from timing out before IoT installation completes * Ensures Predict FVT waits for IoT approval in both pre/post 9.2 scenarios - Fix waitfor-install (Day2) dependencies: Add IoT and Monitor approvals * Add explicit dependencies on approval-iot, approval-iot-after-monitor * Add explicit dependencies on approval-monitor, approval-monitor-before-iot * Ensures Day2 operations don't start prematurely when IoT+Monitor installed without Predict * Removes incorrect assumption that approval-predict implies all apps completed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add app-install-iot-after-monitor as a dependency to both app-install-predict and post-install-verify to ensure:
This addresses both scenarios:
When Predict runs: post-install-verify → app-install-predict → app-install-iot-after-monitor
When Predict is skipped: post-install-verify → app-install-iot-after-monitor (direct dependency)
Fix waitfor-iot dependency: Change from approval-manage to approval-suite-verify
Fix waitfor-predict dependency: Add IoT approval dependencies
Fix waitfor-install (Day2) dependencies: Add IoT and Monitor approvals