Update ChaCha20 and ChaCha20Poly1305 cipher to match expected Cipher behaviour#20
Closed
KostasTsiounis wants to merge 1 commit intoibmruntimes:java11from
Closed
Update ChaCha20 and ChaCha20Poly1305 cipher to match expected Cipher behaviour#20KostasTsiounis wants to merge 1 commit intoibmruntimes:java11from
KostasTsiounis wants to merge 1 commit intoibmruntimes:java11from
Conversation
…behaviour Certain changes have to be made to match the official documentation regarding Cipher instances: - In newer Java versions (11+), init() needs to be called after doFinal() when encrypting. - When performing a doFinal() with a short buffer, a call to init is required. Tests to validate said behaviour are also added or altered accordingly. Signed-off-by: Kostas Tsiounis <kostas.tsiounis@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Certain changes have to be made to match the official documentation regarding
Cipherinstances:init()needs to be called afterdoFinal()when encrypting.doFinal()with a short buffer, a call toinit()is required.Tests to validate said behaviour are also added or altered accordingly.
Back-ported from: IBM#518
Signed-off-by: Kostas Tsiounis kostas.tsiounis@ibm.com