Support SecureRandom strong algorithms in FIPS mode - #620
Support SecureRandom strong algorithms in FIPS mode#620Mohit-Rajbhar100698 wants to merge 1 commit into
Conversation
73fddd3 to
eee6253
Compare
|
Hi @keithc-ca |
| private static Stream<Arguments> patternMatches_strongAlgorithms() { | ||
| Stream.Builder<Arguments> tests = Stream.builder(); | ||
|
|
||
| if (isProviderPresent("OpenJCEPlusFIPS")) { |
There was a problem hiding this comment.
Why is this condition present here (and on line 332), but not in 25 and later versions?
There was a problem hiding this comment.
Yes, @keithc-ca. That condition was removed in another PR: ibmruntimes/openj9-openjdk-jdk#1225.
Once this PR is merged, I'll immediately raise the corresponding backport to remove that condition as well.
Or
If you want I can give that change in this PR also.
There was a problem hiding this comment.
No, let's keep the three changes separate; see ibmruntimes/openj9-openjdk-jdk21#446 (comment).
There was a problem hiding this comment.
Yes, @keithc-ca , got it.
We'll keep the three changes as separate PRs. One PR has already been raised. Once that is merged, I'll raise the remaining two consecutively.
I've also resolved all the merge conflicts on the backports (for jdk21,jdk17,jdk11). Whenever you have a chance, could you please review it?
5f0ce11 to
8854b67
Compare
|
Hi @keithc-ca , is there anything left for me to address in this PR? |
|
Yes, this should not be merged before ibmruntimes/openj9-openjdk-jdk21#446 is merged, which, in turn, is awaiting back-ports of ibmruntimes/openj9-openjdk-jdk#1225 and ibmruntimes/openj9-openjdk-jdk#1232. |
This change overrides the default securerandom.strongAlgorithms configuration used by SecureRandom.getInstanceStrong() when it runs in FIPS mode. This PR also includes two additional backports. One removes the provider-specific condition from the SecureRandom strongAlgorithms test(#1225). The other handles the Windows-specific SecureRandom strongAlgorithms defaults used by the test(#1232). Signed-off-by: Mohit Rajbhar <mohit.rajbhar@ibm.com>
d9adc63 to
f7f084b
Compare
|
Updated this also with all backports |
2 participants
This change overrides the default securerandom.strongAlgorithms
configuration used by SecureRandom.getInstanceStrong() when it
runs in FIPS mode.
This PR also includes two additional backports. One removes the
provider-specific condition from the SecureRandom strongAlgorithms
test. The other handles the Windows-specific SecureRandom
strongAlgorithms defaults used by the test.
Back-ported from: #1187 #1225 #1232
Signed-off-by: Mohit Rajbhar mohit.rajbhar@ibm.com