fix(ime): the candidate window position of fcitx5 which does't work well with winit's set_ime_cursor_area()#3259
Open
kenz-gelsoft wants to merge 2 commits intoiced-rs:masterfrom
Open
Conversation
Contributor
Author
|
Closes #3258 |
5 tasks
kenz-gelsoft
force-pushed
the
fix_linux_cand_pos
branch
from
c226de5 to
e0de4f4
Compare
Contributor
Author
|
rebased on master to fix Document check |
…winit's set_ime_cursor_area() supports only the position)
kenz-gelsoft
force-pushed
the
fix_linux_cand_pos
branch
from
e0de4f4 to
8955d9c
Compare
kenz-gelsoft
changed the title
Contributor
Author
|
I changed this PR title and diff to match the PR that is merged in downstream(pop-os/iced). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a workaround fix of #3258.
As I noted in #3258, this probably be a bug of the winit's Linux implmentation.As I noted in #3258, this seems to be a bug of the fcitx5.
The fcitx5 is just one of the input method frontends on Linux, but it is the de-facto standard on desktop environments other than GNOME which is tightly integrated with the ibus.
This workaround won't break if they will fix their
Linuxfcitx5 implementation to handle the cursor area rectangle consistent with other platforms or the ibus. Because this change specifies zero height rect for Linux which is the left-top corner position (as they documented) == the bottom-left corner position (current actual behavior).