Fix RTL and mixed BiDi text in text_editor and text_input#3294
Draft
hojjatabdollahi wants to merge 5 commits intoiced-rs:masterfrom
Draft
Fix RTL and mixed BiDi text in text_editor and text_input#3294hojjatabdollahi wants to merge 5 commits intoiced-rs:masterfrom
hojjatabdollahi wants to merge 5 commits intoiced-rs:masterfrom
Conversation
hojjatabdollahi
changed the title
This fixes issues with RTL text in `text_editor`
hojjatabdollahi
force-pushed
the
fix-rtl-editor
branch
2 times, most recently
from
efb491e to
50ed8f3
Compare
hojjatabdollahi
force-pushed
the
fix-rtl-editor
branch
from
4fe6299 to
2e86985
Compare
hojjatabdollahi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft until pop-os/cosmic-text#491 is merged.Draft until new cosmic-text release.
This fixes issues with RTL text in
text_editorandtext_input.Currently both hit detection and highlighting is wrong.
This PR switches from the custom highlight algorithm to the one in
cosmic-textforeditor.before:
recording-2026-03-26_18-28-35.mp4
after:
recording-2026-03-26_18-35-31.mp4
This also updates text input widget and adds RTL and mixed bidi support. The changes to text input is bigger, because it's a specialized input (single line, password support, etc), so I had to copy bidi support for it from cosmic-text.
Fixes #1877, #2102, and #1454