Version 1.01 89#534
Open
icefields wants to merge 24 commits into
Open
Conversation
fix submodule URL to be public https instead of ssh
Fixes out of memory exceptions when downloading large files (was trying to hold the entire file in RAM at once, before writing to disk)
Quick fix, but this has to be properly handled in the future. Possibly check if absoluteDirPath actually needs to return nulls at all
- Custom exception: FileWriteException - Annotated SafFolderHelper.writeFile() with @throws(Exception::class) - StorageManagerImpl.saveSong() is now fully wrapped in a try/catch block
Fix track order for multidics albums, ordering by `disk` first, `trackNumber` second. Changes are made to getSongFromAlbum and getOfflineSongsFromAlbum queries, since there were TWO separate cases for "mixed" order to happen: - In online mode, each pull-refresh action on the album screen resulted in an incorrect order for a brief moment, before fixing itself; - In offline mode track order was always incorrect.
Add an option to delete a downloaded song from the song dropdown menu. This includes a confirmation dialog. The action was implemented for every screen where applicable, however some screens currently need to be adjusted to account for checking if the song is downloaded, in order to actually display the action.
Adds a new action to open InfoDialogSong dialog via the SongDropDownMenu
Adds a check for user's access level when constructing the list of playlist to display. If user has admin access, then add all existing playlists to AddToPlaylistOrQueueDialog. Also sorts playlists in a following order, for convenience: owned by current user -> owned by "system" user -> owned by other users
Adds a check for user's access level, in order to allow admin users to be eligible for swiping motion/deletion operation against playlist contents
Add some predefined Ampache access level "groups" and a few helper functions to check access levels of users
Lists are now always sorted by name. If there is additional sorting logic, lists are pre-sorted by name first, then additional filtering is applied. AddToPlaylistsOrQueue dialog ordering was pretty random prior to that change, which is inconvenient from the user standpoint.
Slight changes to how access constants should be stored in User class
Make users with admin access eligible for editing any playlist
Update .gitmodules
…hancements SongDropDownMenu: "Show Info" and "Delete Song" actions
Bug: OutOfMemory crashes with custom download directories
…ist_order Sort album songs list by disc number
…2 into version_1.01-89
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
work in progress
new release version 1.01-89