[ fix ] BoundedQueue1

[Matthew-Mosior]

This PR addresses comments from #66.

[Matthew-Mosior]

@stefan-hoeck

I've addressed all comments in #66 here in this PR, it's ready for review.

[stefan-hoeck]

Code looks good, but I have doubts about the semantics. What are the use cases for a bounded queue, that either silently drops the oldest element (data loss in case of enqueue) or silently fails to enqueue a value in the first place (enqueueIfSpace)? Wouldn't it make more sense to return some kind of flag that informs client code about the success or failure of the operation?

[Matthew-Mosior]

Code looks good, but I have doubts about the semantics. What are the use cases for a bounded queue, that either silently drops the oldest element (data loss in case of enqueue) or silently fails to enqueue a value in the first place (enqueueIfSpace)? Wouldn't it make more sense to return some kind of flag that informs client code about the success or failure of the operation?

Good point here, I've rewritten the function to return a F1 s Bool instead, should be good for a re-review.

[stefan-hoeck]

Good point here, I've rewritten the function to return a F1 s Bool instead, should be good for a re-review.

But there are several functions that try to add a value to a queue. Now only one of them returns a Bool. They should be treated all the same, no?

[Matthew-Mosior]

Good point here, I've rewritten the function to return a F1 s Bool instead, should be good for a re-review.

But there are several functions that try to add a value to a queue. Now only one of them returns a Bool. They should be treated all the same, no?

Yep good catch, prepend needed this fix too. should be good for a re-review.

[Matthew-Mosior]

Thank you for the review!