Draft
Conversation
* Update dependencies * Use updated girs/gjs types in code base * Remove now unnecessary local type definitions * Cleanup tsconfig.json
For the generated JavaScript we use the recommended config in "eslint.config.js". For TypeScript use a separate "eslint.config.mjs" configuration that can be slightly customized.
|
Hi @ifl0w I tried building this extension using this PR and everything seems to be working correctly even the preview (which was not on #221). I'm even running on GNOME 50 (I just simply modified the metadata.json) and everything still works. Any ETA on when we'll get an official release with these changes? Cheers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An initial draft for 48 and 49 support.
Currently I also drop support for < 48 since I currently don't have a setup for testing those versions and testing multiple versions is very time intensive. Unfortunately Gnome 46 is shipped with the latest Ubuntu LTS so I'd rather like to support that version. Maybe I'll test in a VM and try to get 46 working.