docs(faq): use IP_WHITE_LIST for private-network model endpoints - #1580
Open
FenjuFu wants to merge 1 commit into
Open
docs(faq): use IP_WHITE_LIST for private-network model endpoints#1580FenjuFu wants to merge 1 commit into
FenjuFu wants to merge 1 commit into
Conversation
Adding a custom model on a private address (e.g. 192.168.x.x) fails with "URL validation failed" because the SSRF/private-IP policy rejects it before the validation request is sent. The FAQ previously told users to clear the NETWORK_SEGMENT_BLACK_LIST, which is the wrong, less safe workaround. Update the two model FAQ entries to use the IP_WHITE_LIST allowlist added in #1562: whitelist the exact IP/CIDR in both config_info and config_info_en, and keep the blacklist intact. Signed-off-by: FenjuFu <92919259+FenjuFu@users.noreply.github.com>
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #1551.
Why
Adding a custom OpenAI-compatible model on a private-network endpoint (e.g.
http://192.168.60.13:9090/v1/chat/completions) fails with "URL validation failed". As confirmed on #1551, the console backend runs the endpoint through its SSRF / private-IP policy before sending the validation request, so a reachable endpoint is still rejected.The FAQ's existing advice was to clear the
NETWORK_SEGMENT_BLACK_LIST— the wrong and less safe fix. #1562 added an explicitIP_WHITE_LISTallowlist for exactly this case, and that's the intended opt-in.Changes
Update the two affected entries in
faq/models.md:V1.43__add_ip_white_list_config.sqlmigration:category = 'IP_WHITE_LIST',code = 'ip_white_list').Both call out the two things that trip people up: the value must go into both
config_infoandconfig_info_en(the config table is selected by request locale), and the blacklist should be left intact.Docs-only; no code change.