Welcome message originator and raw welcome xmpp message#12
Closed
nsobadzhiev wants to merge 5689 commits into
Closed
Welcome message originator and raw welcome xmpp message#12nsobadzhiev wants to merge 5689 commits into
nsobadzhiev wants to merge 5689 commits into
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduction
In some use cases, it might be necessary to send a welcome message not from the server itself, but on behalf of a particular user. For instance, so people can respond to the welcome message and also see it as if a real account sent it to them (more personal).
Additionally, the plugin assumes that the welcome XMPP message's title will always be the same and that having some nice text in the body is enough. However, the message might have proprietary attributes and child elements. For that reason, I added an additional text field for adding a raw XML representation of the message to send.
The raw message XML takes precedence over the simple, textual one.
If there's no message originator set, the server address is used by default.