fix field labels when using ldap#17
Open
mightymop wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
When will u review / merge this PR? |
mightymop
force-pushed
the
fix_labelrebase
branch
2 times, most recently
from
ed63ad1 to
ea8b89d
Compare
Contributor
Author
|
@guusdk: i have rebased it to current master... |
mightymop
force-pushed
the
fix_labelrebase
branch
from
ea8b89d to
a1fe495
Compare
fix: fill all columns with result data
mightymop
force-pushed
the
fix_labelrebase
branch
from
a1fe495 to
01fa8cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-fix labels when using extendes ldap search fields
-fill all fields with result data
This PR adds the ability to define the labels (for one language) in ldap.searchFields like:
Name/displayName,Alias/mailNickname,Dienststelle/department,EMail/mail,Tel/telephoneNumber,...
Furthermore the result fields in the result table will be filled with data from ldap too.
A further positive sideeffect of this PR: field count will be equal to reported field count => so no extra checks and search algos to find the right index to build the result table are needed in theory...
fix #16