Skip to content

Refactoring and code cleanup#29

Merged
guusdk merged 2 commits into
igniterealtime:mainfrom
stokito:refactor
Sep 15, 2025
Merged

Refactoring and code cleanup#29
guusdk merged 2 commits into
igniterealtime:mainfrom
stokito:refactor

Conversation

@stokito

@stokito stokito commented Sep 14, 2025

Copy link
Copy Markdown
Member

Replaced the manual iterator manipulation with a direct iteration on elements() that are anyway used internally:

    public Iterator<Element> elementIterator() {
        List<Element> list = this.elements();
        return list.iterator();
    }

    public Iterator<Element> elementIterator(String name) {
        List<Element> list = this.elements(name);
        return list.iterator();
    }

Use switch instead of if chain.
Use CASE_INSENSITIVE_ORDER

@guusdk guusdk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm generally in favor of this, but if we're going to change the way we implement properties, we should migrate from JiveGlobals to org.jivesoftware.util.SystemProperty. Can you make that part of this PR please?

@stokito

stokito commented Sep 15, 2025

Copy link
Copy Markdown
Member Author

I don't know yet how to do that so let's do that in a separate PR later.

@guusdk guusdk merged commit 2eb6f2c into igniterealtime:main Sep 15, 2025
3 checks passed
@stokito stokito deleted the refactor branch September 15, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants