Conversation
Not up to standards ⛔
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A formatting and documentation cleanup pass on top of the numpy 2
compatibility fixes. No runtime behavior changes — this is purely
style, docstrings, and lint hygiene.
ruff formatacross the package, tests, andsetup.py(quote style, spacing, line wrapping).
Args:/Returns:) toNumPy style (
Parameters/Returnswith underlines).What changed
src/xspline/core.py,src/xspline/utils.py) —converted every function/method to NumPy style. Argument types are
dropped from the docstrings (to be carried by type hints later);
return types are kept.
XSpline/NDXSplineconstructorparameters moved into the class docstring with an
Attributessection. Dropped the
r"""prefixes (no docstring uses backslashes)and removed the module-level docstrings/header comments.
src/xspline/__init__.py) — replacedfrom .core import *with explicit imports and an explicit__all__listing the fourbspline_*functions and theXSpline/NDXSplineclasses.setup.py,src/xspline/__about__.py, all oftests/) —ruff formatreflow and import-order fixes; removed anunused variable in
tests/test_xspline.py.