Fix Docker template data volume#29
Conversation
|
Warning Review limit reached
More reviews will be available in 42 minutes and 46 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe Docker image and compose service stop exposing port ChangesRuntime ports and persistence
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related issues
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
iii/docker/docker-compose.yml (1)
7-14: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winKeep the Prometheus port as a documented opt-in mapping.
motia/quickstart/iii.config.yaml:139-142still targets9464whenmetrics_exporterincludesprometheus. After this change, enabling that mode in the generated Docker setup leaves the endpoint unreachable from the host because the template no longer shows any9464:9464mapping. Consider keeping it as a commented-out port entry, similar to the49135note, so the metrics path remains discoverable.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@iii/docker/docker-compose.yml` around lines 7 - 14, The Docker compose template is missing the Prometheus host port mapping, so the metrics endpoint becomes undiscoverable when metrics_exporter is enabled. Update the docker-compose service definition to keep a commented-out opt-in `9464:9464` ports entry, similar to the existing `49135` note, and make sure the `ports` block in the compose template still documents the metrics path for the service that exposes Prometheus metrics.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@iii/docker/docker-compose.yml`:
- Around line 7-14: The Docker compose template is missing the Prometheus host
port mapping, so the metrics endpoint becomes undiscoverable when
metrics_exporter is enabled. Update the docker-compose service definition to
keep a commented-out opt-in `9464:9464` ports entry, similar to the existing
`49135` note, and make sure the `ports` block in the compose template still
documents the metrics path for the service that exposes Prometheus metrics.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 819d10f4-2d13-4e0b-9d96-de0ec983c358
📒 Files selected for processing (2)
iii/docker/Dockerfileiii/docker/docker-compose.yml
7a5a777 to
b3850c1
Compare
fabda2e to
72a6755
Compare
|
Superseded by #31. The original PR head did not synchronize after updating the fork branch to preserve scripts/smoke-init.sh as executable. |
What
iii_datavolume at/app/datain the generated Docker compose template.iii_datavolume at the top level.9464exposure from the generated Dockerfile and compose template.iii project init --dockerand assert the generated Docker assets include the data volume.Why
This fixes the generated-template side of iii-hq/iii#1883. On Linux, the engine image runs as non-root UID 65532 and the configuration worker defaults to
./data/configurationunder/app, so freshiii project init --docker && docker compose upcan crash-loop withPermission deniedunless/app/datais writable.Notes
iii_data:/app/data,bash -n scripts/smoke-init.sh, and diff whitespace check.