Skip to content

Fix Docker template data volume#29

Closed
snvtac wants to merge 1 commit into
iii-hq:mainfrom
snvtac:snvtac/1883-docker-compose-data-volume
Closed

Fix Docker template data volume#29
snvtac wants to merge 1 commit into
iii-hq:mainfrom
snvtac:snvtac/1883-docker-compose-data-volume

Conversation

@snvtac

@snvtac snvtac commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

What

  • Mount a named iii_data volume at /app/data in the generated Docker compose template.
  • Declare the iii_data volume at the top level.
  • Drop the stale 9464 exposure from the generated Dockerfile and compose template.
  • Extend the init smoke script to exercise iii project init --docker and assert the generated Docker assets include the data volume.

Why

This fixes the generated-template side of iii-hq/iii#1883. On Linux, the engine image runs as non-root UID 65532 and the configuration worker defaults to ./data/configuration under /app, so fresh iii project init --docker && docker compose up can crash-loop with Permission denied unless /app/data is writable.

Notes

  • Companion engine image/fixture PR: Fix Docker data directory permissions iii#1910
  • Validation run: YAML parse for this compose file, semantic check for iii_data:/app/data, bash -n scripts/smoke-init.sh, and diff whitespace check.
  • Docker smoke was not run here because Docker CLI is unavailable in this environment.

@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@snvtac, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 42 minutes and 46 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c0fb3abb-3abb-4258-81c4-4cb3a42517f4

📥 Commits

Reviewing files that changed from the base of the PR and between 7a5a777 and 72a6755.

📒 Files selected for processing (3)
  • iii/docker/Dockerfile
  • iii/docker/docker-compose.yml
  • scripts/smoke-init.sh
📝 Walkthrough

Walkthrough

The Docker image and compose service stop exposing port 9464, and the compose file now declares a named iii_data volume for /app/data.

Changes

Runtime ports and persistence

Layer / File(s) Summary
Ports and volume declaration
iii/docker/Dockerfile, iii/docker/docker-compose.yml
EXPOSE and compose ports remove 9464, and compose declares iii_data as a named volume for /app/data.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related issues

  • iii-hq/iii#1883: Matches the same Docker image/compose setup changes, including removal of port 9464 and the iii_data volume.

Possibly related PRs

  • iii-hq/templates#2: Directly overlaps with the same Docker template/configuration area that exposes 9464 in the image and compose setup.

Poem

🐰 I hopped by the Docker gate,
and found one port had left the state.
The iii_data burrow grew snug and neat,
while quiet little containers kept their beat.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the main change by describing the Docker template data volume fix.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
iii/docker/docker-compose.yml (1)

7-14: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick win

Keep the Prometheus port as a documented opt-in mapping.

motia/quickstart/iii.config.yaml:139-142 still targets 9464 when metrics_exporter includes prometheus. After this change, enabling that mode in the generated Docker setup leaves the endpoint unreachable from the host because the template no longer shows any 9464:9464 mapping. Consider keeping it as a commented-out port entry, similar to the 49135 note, so the metrics path remains discoverable.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@iii/docker/docker-compose.yml` around lines 7 - 14, The Docker compose
template is missing the Prometheus host port mapping, so the metrics endpoint
becomes undiscoverable when metrics_exporter is enabled. Update the
docker-compose service definition to keep a commented-out opt-in `9464:9464`
ports entry, similar to the existing `49135` note, and make sure the `ports`
block in the compose template still documents the metrics path for the service
that exposes Prometheus metrics.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@iii/docker/docker-compose.yml`:
- Around line 7-14: The Docker compose template is missing the Prometheus host
port mapping, so the metrics endpoint becomes undiscoverable when
metrics_exporter is enabled. Update the docker-compose service definition to
keep a commented-out opt-in `9464:9464` ports entry, similar to the existing
`49135` note, and make sure the `ports` block in the compose template still
documents the metrics path for the service that exposes Prometheus metrics.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 819d10f4-2d13-4e0b-9d96-de0ec983c358

📥 Commits

Reviewing files that changed from the base of the PR and between 2fc75e1 and 7a5a777.

📒 Files selected for processing (2)
  • iii/docker/Dockerfile
  • iii/docker/docker-compose.yml

@snvtac snvtac force-pushed the snvtac/1883-docker-compose-data-volume branch from 7a5a777 to b3850c1 Compare June 25, 2026 17:38
@snvtac snvtac force-pushed the snvtac/1883-docker-compose-data-volume branch from fabda2e to 72a6755 Compare June 25, 2026 17:47
@snvtac

snvtac commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #31. The original PR head did not synchronize after updating the fork branch to preserve scripts/smoke-init.sh as executable.

@snvtac snvtac closed this Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant