Security: Potential XSS in HTML rendering bridge (unsanitized attributes/URLs)#1009
Open
Security: Potential XSS in HTML rendering bridge (unsanitized attributes/URLs)#1009
Conversation
The mp-html bridge renderer builds DOM nodes from provided content and applies attributes directly via `setAttribute` without a visible allowlist/sanitization step. If untrusted HTML/content reaches `window.setContent(...)`, attacker-controlled attributes such as dangerous `href/src` values (e.g., `javascript:` / `data:` payloads depending on runtime behavior) or other injected markup could execute script in the embedded webview context. Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
The mp-html bridge renderer builds DOM nodes from provided content and applies attributes directly via `setAttribute` without a visible allowlist/sanitization step. If untrusted HTML/content reaches `window.setContent(...)`, attacker-controlled attributes such as dangerous `href/src` values (e.g., `javascript:` / `data:` payloads depending on runtime behavior) or other injected markup could execute script in the embedded webview context. Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security: Potential XSS in HTML rendering bridge (unsanitized attributes/URLs)
Problem
Severity:
High| File:src/static/app-plus/mp-html/js/handler.js:L1The mp-html bridge renderer builds DOM nodes from provided content and applies attributes directly via
setAttributewithout a visible allowlist/sanitization step. If untrusted HTML/content reacheswindow.setContent(...), attacker-controlled attributes such as dangeroushref/srcvalues (e.g.,javascript:/data:payloads depending on runtime behavior) or other injected markup could execute script in the embedded webview context.Solution
Add strict sanitization before DOM construction: use an allowlist of tags and attributes, explicitly strip event-handler attributes (
on*), and validate URL-bearing attributes (src,href,xlink:href) to only permit safe schemes (e.g.,https:). Consider using a vetted sanitizer (DOMPurify-equivalent for the target runtime) before callingsetContent.Changes
src/static/app-plus/mp-html/js/handler.js(modified)src/static/app-plus/up-canvas/local.html(modified)