Skip to content

enhance: Refactor static icons to static/icons directory for cleaner public directory#729

Open
smit-io wants to merge 5 commits into
imfing:mainfrom
smit-io:tidy-icons
Open

enhance: Refactor static icons to static/icons directory for cleaner public directory#729
smit-io wants to merge 5 commits into
imfing:mainfrom
smit-io:tidy-icons

Conversation

@smit-io

@smit-io smit-io commented Jul 31, 2025

Copy link
Copy Markdown

moved png, ico and svg to static/favicons so the icons are not in the root directory in public/.

Directory structure is a bit better.

Files moved (from static to static/favicons):

  1. android-chrome-192x192.png
  2. anrdoid-chrome-512x512.png
  3. apple-touch-icon.png
  4. favicon-16x16.png
  5. favicon-32x32.png
  6. favicon-dark.svg
  7. favicon.ico
  8. facivon.svg

Before

public/
.
├── 404.html
├── android-chrome-192x192.png
├── android-chrome-512x512.png
├── apple-touch-icon.png
├── assets
├── categories
├── CNAME
├── css
├── docs
├── dotfiles
├── en.search-data.json
├── en.search.js
├── en.search.min.ad7d0ec37768b2a520aa72ebd00b985d231828f5d8f028d0e0999e529fdee14a.js
├── en.yaml
├── favicon-16x16.png
├── favicon-32x32.png
├── favicon-dark.svg
├── favicon.ico
├── favicon.svg
├── .git
├── images
├── index.html
├── index.xml
├── js
├── restic
├── robots.txt
├── sitemap.xml
├── site.webmanifest
└── tags

After

public/
├── 404.html
├── categories
├── css
├── docs
├── en.search-data.json
├── en.search.js
├── favicons
│   ├── android-chrome-192x192.png
│   ├── android-chrome-512x512.png
│   ├── apple-touch-icon.png
│   ├── favicon-16x16.png
│   ├── favicon-32x32.png
│   ├── favicon-dark.svg
│   ├── favicon.ico
│   └── favicon.svg
├── images
│   ├── logo-dark.svg
│   └── logo.svg
├── index.html
├── index.xml
├── js
│   ├── flexsearch.9f5b5908f93ae86f1ecd4b043b799f580c2d1654e703dd9357d568ac41b2547a.js
│   └── main.js
├── sitemap.xml
├── site.webmanifest
└── tags

@netlify

netlify Bot commented Jul 31, 2025

Copy link
Copy Markdown

Deploy Preview for hugo-hextra ready!

Name Link
🔨 Latest commit f83e836
🔍 Latest deploy log https://app.netlify.com/projects/hugo-hextra/deploys/688af362c6d8a900086c3fa9
😎 Deploy Preview https://deploy-preview-729--hugo-hextra.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@imfing imfing left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about using "favicons" instead of "icons," which sounds more specific?

@smit-io

smit-io commented Aug 16, 2025

Copy link
Copy Markdown
Author

Sure, I can do that. Do you want me to proceed with that change?

@imfing

imfing commented Aug 16, 2025

Copy link
Copy Markdown
Owner

Sure, I can do that. Do you want me to proceed with that change?

go ahead, please also resolve the merge conflicts

@imfing

imfing commented Aug 26, 2025

Copy link
Copy Markdown
Owner

@smit-io do you plan to work on this or should I close it?

@smit-io

smit-io commented Sep 28, 2025

Copy link
Copy Markdown
Author

Yes. I will make the changes soon.

@netlify

netlify Bot commented Oct 9, 2025

Copy link
Copy Markdown

Deploy Preview for hugo-hextra ready!

Name Link
🔨 Latest commit 52b0261
🔍 Latest deploy log https://app.netlify.com/projects/hugo-hextra/deploys/68ef9b7aec8932000857a5a5
😎 Deploy Preview https://deploy-preview-729--hugo-hextra.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@smit-io

smit-io commented Oct 9, 2025

Copy link
Copy Markdown
Author

changes are done

@imfing

imfing commented Oct 11, 2025

Copy link
Copy Markdown
Owner

changes are done

Please resolve the conflicts

@smit-io

smit-io commented Oct 13, 2025

Copy link
Copy Markdown
Author

Done

Comment thread static/favicons/favicon-dark.svg Outdated

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has been moved to docs site, please remove it

@smit-io

smit-io commented Oct 15, 2025

Copy link
Copy Markdown
Author

I have removed it, anything else I am missing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants