Skip to content

fix(mobile): delete local check for merged assets - #25514

Closed
timonrieger wants to merge 1 commit into
immich-app:mainfrom
timonrieger:fix/false-noop-on-delete
Closed

fix(mobile): delete local check for merged assets#25514
timonrieger wants to merge 1 commit into
immich-app:mainfrom
timonrieger:fix/false-noop-on-delete

Conversation

@timonrieger

@timonrieger timonrieger commented Jan 25, 2026

Copy link
Copy Markdown
Collaborator

Replace selectionAssetState.hasLocal with computed hasLocal variable in delete local logic to properly handle merged assets that have local copies.

@immich-push-o-matic

immich-push-o-matic Bot commented Jan 25, 2026

Copy link
Copy Markdown
Contributor

Label error. Requires exactly 1 of: changelog:.*. Found: 📱mobile. A maintainer will add the required label.

label: "control_bottom_app_bar_delete_from_local".tr(),
onPressed: enabled
? () {
if (!hasLocal) {

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol, seems like git has an issue identifying this as the only line that changed

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file in main has CRLF line endings, but your commit converts them all to LF.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah thanks, that makes sense. Easy to blame the tool first 🤣

@shenlong-tanwen

Copy link
Copy Markdown
Member

This is part of the old-timeline which will soon be removed. Features or fixes are no longer made to the widgets used exclusively in the old-timeline

@timonrieger

Copy link
Copy Markdown
Collaborator Author

This is part of the old-timeline which will soon be removed. Features or fixes are no longer made to the widgets used exclusively in the old-timeline

thanks, thats good to know 😄

@timonrieger
timonrieger deleted the fix/false-noop-on-delete branch January 26, 2026 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants