Skip to content

Fingertip with stateless DANE#36

Open
randomlogin wants to merge 173 commits intoimperviousinc:mainfrom
randomlogin:main
Open

Fingertip with stateless DANE#36
randomlogin wants to merge 173 commits intoimperviousinc:mainfrom
randomlogin:main

Conversation

@randomlogin
Copy link
Copy Markdown

Incorporated changes to replace letsdane with sane.

Copy link
Copy Markdown
Collaborator

@rithvikvibhu rithvikvibhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments and just a few other changes:

  • Remove block height from tray menu and help page
  • remove stop/start from tray menu or use it to enable/disable tunneling
  • update TLD list (tld.go) in fingertip and sane

main.go Outdated
}
if hnsdCheckpointPath == "" {
home, _ := os.UserHomeDir() //above already fails if it doesn't exist
hnsdCheckpointPath = path.Join(home, ".hnsd")
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of a new directory, we can probably use fingertip's existing one so all data stays in one place: app.config.Path

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure which is better: if user also has hnsd, then it's better to share the checkpoints location with hnsd.

Copy link
Copy Markdown
Collaborator

@rithvikvibhu rithvikvibhu Mar 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh forgot about this. If hnsd changes any file format in the future, it shouldn't affect fingertip. Same reason why Bob stores hsd data in its own directory, not in ~/.hsd.

It's also easier for the uninstaller to clean up, deleting one folder clears everything, and doesn't break any other hnsd that may still be installed independently.

And since we're using -t, even the first sync will be pretty fast anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants