Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the wallet to support presenting VCDM 2.0 vc+sd-jwt credentials in OID4VP flows, and refreshes referenced OpenID specification versions/links.
Changes:
- Update OID4VP credential matching/evaluation to handle
vc+sd-jwtdisclosures using the newDecodedPresentations-based evaluation API. - Add VP token building support for
Format::VcSdJwt(VCDM 2.0 SD-JWT) alongside existingjwt_vc_jsonanddc+sd-jwtpaths. - Bump spec references in the “About” page and adjust workspace dependency pins/patching to support the new upstream APIs.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| unime/src/routes/(app)/me/settings/about/+page.ts | Updates displayed OID4VCI/OID4VP spec version strings and URLs to final 1.0 documents. |
| identity-wallet/src/state/qr_code/reducers/read_authorization_request.rs | Updates DCQL credential matching to properly parse/evaluate vc+sd-jwt and adapt to DecodedPresentations. |
| identity-wallet/src/state/credentials/reducers/handle_oid4vp_authorization_request.rs | Adds vc+sd-jwt handling during evaluation and VP token construction; adapts to new OID4VP token APIs. |
| Cargo.toml | Updates oid4vc git revision and adds identity crate patch overrides required by the new dependency graph. |
| Cargo.lock | Locks updated dependency sources and new transitive dependencies from the updated oid4vc revision. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
6 tasks
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Implements presentation of VCDM 2.0 SD-JWT encoded Credentials
Links to any relevant issues
n/a
How the change has been tested
See impierce/ssi-agent#299 for manual testing instructions.
Definition of Done checklist
Add an
xto the boxes that are relevant to your changes.