Skip to content

feat: present VCDM 2.0 SD-JWT Credentials#710

Open
nanderstabel wants to merge 7 commits intodevfrom
feat/present-vcdm2-sd-jwt
Open

feat: present VCDM 2.0 SD-JWT Credentials#710
nanderstabel wants to merge 7 commits intodevfrom
feat/present-vcdm2-sd-jwt

Conversation

@nanderstabel
Copy link
Copy Markdown
Contributor

@nanderstabel nanderstabel commented Mar 12, 2026

Description of change

Implements presentation of VCDM 2.0 SD-JWT encoded Credentials

Links to any relevant issues

n/a

How the change has been tested

See impierce/ssi-agent#299 for manual testing instructions.

Definition of Done checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@nanderstabel nanderstabel self-assigned this Mar 12, 2026
@nanderstabel nanderstabel added the Added A new feature that requires a minor release. label Mar 12, 2026
@nanderstabel nanderstabel requested a review from Copilot March 12, 2026 12:52
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the wallet to support presenting VCDM 2.0 vc+sd-jwt credentials in OID4VP flows, and refreshes referenced OpenID specification versions/links.

Changes:

  • Update OID4VP credential matching/evaluation to handle vc+sd-jwt disclosures using the new DecodedPresentations-based evaluation API.
  • Add VP token building support for Format::VcSdJwt (VCDM 2.0 SD-JWT) alongside existing jwt_vc_json and dc+sd-jwt paths.
  • Bump spec references in the “About” page and adjust workspace dependency pins/patching to support the new upstream APIs.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
unime/src/routes/(app)/me/settings/about/+page.ts Updates displayed OID4VCI/OID4VP spec version strings and URLs to final 1.0 documents.
identity-wallet/src/state/qr_code/reducers/read_authorization_request.rs Updates DCQL credential matching to properly parse/evaluate vc+sd-jwt and adapt to DecodedPresentations.
identity-wallet/src/state/credentials/reducers/handle_oid4vp_authorization_request.rs Adds vc+sd-jwt handling during evaluation and VP token construction; adapts to new OID4VP token APIs.
Cargo.toml Updates oid4vc git revision and adds identity crate patch overrides required by the new dependency graph.
Cargo.lock Locks updated dependency sources and new transitive dependencies from the updated oid4vc revision.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread Cargo.toml Outdated
Comment thread Cargo.toml
Comment thread identity-wallet/src/state/qr_code/reducers/read_authorization_request.rs Outdated
@nanderstabel nanderstabel added the Blocked An issue that is blocked by another issue or another blocker. label Mar 12, 2026
@nanderstabel nanderstabel marked this pull request as ready for review March 12, 2026 15:52
@nanderstabel nanderstabel removed the Blocked An issue that is blocked by another issue or another blocker. label Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Added A new feature that requires a minor release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants