Skip to content

feat: improve responsive navbar UX and align full stack quality updates (waiting for approval) #130

Open
bhaktofmahakal wants to merge 19 commits into
imsks:developmentfrom
bhaktofmahakal:copilot/suggest-useful-contributions
Open

feat: improve responsive navbar UX and align full stack quality updates (waiting for approval) #130
bhaktofmahakal wants to merge 19 commits into
imsks:developmentfrom
bhaktofmahakal:copilot/suggest-useful-contributions

Conversation

@bhaktofmahakal

Copy link
Copy Markdown
Contributor

This PR delivers meaningful frontend and backend quality improvements, with the most visible impact on navigation usability.

what's improved

  • Enhanced frontend UX with a more reliable responsive navbar experience.
  • Added/improved mobile navigation behavior (including burger menu flow and accessibility labels).
  • Improved desktop navigation usability with better structure/scroll handling.
  • Included supporting test and code-quality updates to keep behavior stable.

Why this is useful

  • Better navigation clarity on both mobile and desktop.
  • Improved usability and production-readiness for real users.
  • Cleaner contributor/reviewer experience through scoped, test-backed changes.

Screenshots for review

Copilot AI and others added 12 commits March 1, 2026 14:54
Co-authored-by: bhaktofmahakal <113044681+bhaktofmahakal@users.noreply.github.com>
Co-authored-by: bhaktofmahakal <113044681+bhaktofmahakal@users.noreply.github.com>
…ects

Co-authored-by: bhaktofmahakal <113044681+bhaktofmahakal@users.noreply.github.com>
Co-authored-by: bhaktofmahakal <113044681+bhaktofmahakal@users.noreply.github.com>
Co-authored-by: bhaktofmahakal <113044681+bhaktofmahakal@users.noreply.github.com>
Co-authored-by: bhaktofmahakal <113044681+bhaktofmahakal@users.noreply.github.com>
Co-authored-by: bhaktofmahakal <113044681+bhaktofmahakal@users.noreply.github.com>
…nings

Co-authored-by: bhaktofmahakal <113044681+bhaktofmahakal@users.noreply.github.com>
Co-authored-by: bhaktofmahakal <113044681+bhaktofmahakal@users.noreply.github.com>
Co-authored-by: bhaktofmahakal <113044681+bhaktofmahakal@users.noreply.github.com>
…menu

Co-authored-by: bhaktofmahakal <113044681+bhaktofmahakal@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 1, 2026 18:05
@vercel

vercel Bot commented Mar 1, 2026

Copy link
Copy Markdown
Contributor

@Copilot is attempting to deploy a commit to the Sachin's Projects Team on Vercel.

A member of the Team first needs to authorize it.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR focuses on improving frontend navigation and UI polish (responsive navbar, updated iconography, interactive card treatment) while adding/adjusting unit tests to keep the updated behavior stable.

Changes:

  • Refactors the Navbar for improved responsive behavior (scrollable desktop nav, mobile burger menu, accessibility labels) and updates Footer styling.
  • Introduces a reusable SpotlightCard component and applies it to cards on the homepage and politician list.
  • Adds/updates Jest tests to cover the new UI components and key homepage/navbar/footer behaviors.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
readme.md Minor markdown cleanup.
frontend/lib/api/user.ts Updates API base URL handling and removes debug logging.
frontend/components/ui/SpotlightCard.tsx Adds new interactive spotlight/hover card component.
frontend/components/ui/Button.tsx Updates internal link rendering (removes legacyBehavior/anchor wrapper) and fixes prop forwarding.
frontend/components/layout/Navbar.tsx Responsive navbar refactor with desktop scroll nav + mobile menu and better a11y labeling.
frontend/components/layout/Footer.tsx Footer styling refresh and swaps inline SVG for lucide icon.
frontend/components/PreambleSection.tsx Rounds SVG spoke coordinates to fixed precision.
frontend/components/PoliticianCard.tsx Replaces motion.div hover wrapper with SpotlightCard.
frontend/app/page.tsx Replaces emoji icons with lucide icons, applies SpotlightCard, and tweaks motion initial behavior.
frontend/tests/components/SpotlightCard.test.tsx Adds unit tests for SpotlightCard rendering + CSS variable updates.
frontend/tests/components/PreambleSection.test.tsx Adds test ensuring fixed-precision spoke coordinates.
frontend/tests/components/Navbar.test.tsx Adds tests for desktop nav rendering, dashboard links, and mobile menu toggle.
frontend/tests/components/Footer.test.tsx Adds test for footer content and GitHub link.
frontend/tests/components/Button.test.tsx Adds test ensuring icon props aren’t forwarded to DOM for link buttons.
frontend/tests/app/homepage-sections.test.tsx Adds tests ensuring key sections render and emojis are removed from feature cards.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread frontend/__tests__/components/Navbar.test.tsx Outdated
Comment thread frontend/lib/api/user.ts Outdated
@bhaktofmahakal bhaktofmahakal changed the title feat: improve responsive navbar UX and align full-stack quality updates feat: improve responsive navbar UX and align full-stack quality updates (waiting for approval) Mar 1, 2026
@bhaktofmahakal bhaktofmahakal changed the title feat: improve responsive navbar UX and align full-stack quality updates (waiting for approval) feat: improve responsive navbar UX and align full stack quality updates (waiting for approval) Mar 1, 2026
@bhaktofmahakal

Copy link
Copy Markdown
Contributor Author

Waiting for Approval from maintainer(SKS).

imsks and others added 2 commits March 5, 2026 12:37
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI and others added 2 commits March 5, 2026 10:55
…te nav state

Co-authored-by: bhaktofmahakal <113044681+bhaktofmahakal@users.noreply.github.com>
Co-authored-by: bhaktofmahakal <113044681+bhaktofmahakal@users.noreply.github.com>
@imsks

imsks commented Mar 6, 2026

Copy link
Copy Markdown
Owner

@bhaktofmahakal Fix the conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants