feat: improve responsive navbar UX and align full stack quality updates (waiting for approval) #130
Open
bhaktofmahakal wants to merge 19 commits into
Open
Conversation
Co-authored-by: bhaktofmahakal <113044681+bhaktofmahakal@users.noreply.github.com>
Co-authored-by: bhaktofmahakal <113044681+bhaktofmahakal@users.noreply.github.com>
…ects Co-authored-by: bhaktofmahakal <113044681+bhaktofmahakal@users.noreply.github.com>
Co-authored-by: bhaktofmahakal <113044681+bhaktofmahakal@users.noreply.github.com>
Co-authored-by: bhaktofmahakal <113044681+bhaktofmahakal@users.noreply.github.com>
Co-authored-by: bhaktofmahakal <113044681+bhaktofmahakal@users.noreply.github.com>
Co-authored-by: bhaktofmahakal <113044681+bhaktofmahakal@users.noreply.github.com>
…nings Co-authored-by: bhaktofmahakal <113044681+bhaktofmahakal@users.noreply.github.com>
Co-authored-by: bhaktofmahakal <113044681+bhaktofmahakal@users.noreply.github.com>
Co-authored-by: bhaktofmahakal <113044681+bhaktofmahakal@users.noreply.github.com>
…menu Co-authored-by: bhaktofmahakal <113044681+bhaktofmahakal@users.noreply.github.com>
Contributor
|
@Copilot is attempting to deploy a commit to the Sachin's Projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR focuses on improving frontend navigation and UI polish (responsive navbar, updated iconography, interactive card treatment) while adding/adjusting unit tests to keep the updated behavior stable.
Changes:
- Refactors the Navbar for improved responsive behavior (scrollable desktop nav, mobile burger menu, accessibility labels) and updates Footer styling.
- Introduces a reusable
SpotlightCardcomponent and applies it to cards on the homepage and politician list. - Adds/updates Jest tests to cover the new UI components and key homepage/navbar/footer behaviors.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| readme.md | Minor markdown cleanup. |
| frontend/lib/api/user.ts | Updates API base URL handling and removes debug logging. |
| frontend/components/ui/SpotlightCard.tsx | Adds new interactive spotlight/hover card component. |
| frontend/components/ui/Button.tsx | Updates internal link rendering (removes legacyBehavior/anchor wrapper) and fixes prop forwarding. |
| frontend/components/layout/Navbar.tsx | Responsive navbar refactor with desktop scroll nav + mobile menu and better a11y labeling. |
| frontend/components/layout/Footer.tsx | Footer styling refresh and swaps inline SVG for lucide icon. |
| frontend/components/PreambleSection.tsx | Rounds SVG spoke coordinates to fixed precision. |
| frontend/components/PoliticianCard.tsx | Replaces motion.div hover wrapper with SpotlightCard. |
| frontend/app/page.tsx | Replaces emoji icons with lucide icons, applies SpotlightCard, and tweaks motion initial behavior. |
| frontend/tests/components/SpotlightCard.test.tsx | Adds unit tests for SpotlightCard rendering + CSS variable updates. |
| frontend/tests/components/PreambleSection.test.tsx | Adds test ensuring fixed-precision spoke coordinates. |
| frontend/tests/components/Navbar.test.tsx | Adds tests for desktop nav rendering, dashboard links, and mobile menu toggle. |
| frontend/tests/components/Footer.test.tsx | Adds test for footer content and GitHub link. |
| frontend/tests/components/Button.test.tsx | Adds test ensuring icon props aren’t forwarded to DOM for link buttons. |
| frontend/tests/app/homepage-sections.test.tsx | Adds tests ensuring key sections render and emojis are removed from feature cards. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Waiting for Approval from maintainer(SKS). |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…te nav state Co-authored-by: bhaktofmahakal <113044681+bhaktofmahakal@users.noreply.github.com>
Co-authored-by: bhaktofmahakal <113044681+bhaktofmahakal@users.noreply.github.com>
Owner
|
@bhaktofmahakal Fix the conflicts |
Co-authored-by: bhaktofmahakal <113044681+bhaktofmahakal@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR delivers meaningful frontend and backend quality improvements, with the most visible impact on navigation usability.
what's improved
Why this is useful
Screenshots for review