Prevent duplicate entries in LbsLobby.Entry#360
Merged
Conversation
Entry() appended to EntryUsers without checking for duplicates. This caused incorrect match entry counts and could lead to a user being picked multiple times in lobby battle selection. Add duplicate guard in Entry() so the same user cannot be added to EntryUsers more than once. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The old bash uploader (codecov.io/bash) has been deprecated and now returns an HTML error page, causing the CI upload step to fail. Replace with codecov/codecov-action@v5. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Entry()appended toEntryUserswithout dedup check, allowing the same user to appear multiple timesGetLobbyMatchEntryUserCount()results and could lead to a user being picked multiple times inpickLobbyBattleParticipants()Entry()if the user is already inEntryUsersTest plan
TestLbsLobby_Entry_NoDuplicate— callsEntry()twice with same user, verifies only one entryEntryCancel,EntryPicked,Exittests still passmake test/make lintclean